Fix meson build by adding missing files #38982
Merged
+4
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Documentation preview for this PR (built with commit f211bdc; changes) is ready! 🎉 |
|
If this would not fix "Build & Test using Meson", please consider turn it off to be information only. |
|
Thanks for the review!
I understand the frustration. Disabling the workflow would however be counter productive since meson is supposed to be the replacement of the old setuptools-based build. Would love to hear your thoughts on how to archive that without making the transition period to annoying. (I will also open a discussion on sage-dev about this in the coming days.) |
tobiasdiez
force-pushed
the
fix-meson
branch
from
6ad795f
to
f211bdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the meson build.
📝 Checklist
⌛ Dependencies